search

RocketMod / Rocket.Unturned

Unturned 3 implementation of the RocketMod — .NET Game Server Plugin Framework
MIT License
85 stars 111 forks source link

Re-added removed vanish, etc. which was just 2 libraries missing. (LEGACY BRANCH) #92

Closed Pustalorc closed 5 years ago

Pustalorc commented 5 years ago

Honestly, it only needed 2 other UnityEngine libraries to compile again without any complain on vanish, or HUD, or anything really... I have no idea why this wasn't done originally, but whatever. Compiles again and no features are randomly removed.

fr34kyn01535 commented 5 years ago

Why exactly did you readd HUD.cs? It was just for testing. Before this gets merged the build script must be changed accordingly.

Pustalorc commented 5 years ago

Because you commented it out on your recent commits and you specified on discord that you did so because it didn't compile:

PustalorcToday at 3:01 PM Sven, may I ask why remove ongui code as well as vanish? SvenToday at 3:11 PM feel free to fix it it didn't compile

"ongui code" was referring to HUD.cs

Trojaner commented 5 years ago

HUD.cs was added as a test when Nelson introduced client side modules. Since client side modules got removed again some months ago, there is no need for it all anymore.

Pustalorc commented 5 years ago

Removed HUD.cs again in that case then, this time completely and still with the ability to compile Rocket.Unturned.