RocketPy-Team / RocketPy

Next generation High-Power Rocketry 6-DOF Trajectory Simulation
https://docs.rocketpy.org/
MIT License
616 stars 146 forks source link

MNT: Modularize Rocket Draw #580

Closed MateusStano closed 5 months ago

MateusStano commented 6 months ago

Pull request type

Checklist

Current behavior

The method of _RocketPlots relating to the rocket drawing was too big and hard to change/improve/maintain

New behavior

The .draw() method has been separated into several different methods. No code relating to the plot has been changed.

Breaking change

Additional information

I was trying to add sensors to the drawing and it was really hard to work with the drawing, so I refactored it.

A quick note:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 94.28571% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 72.94%. Comparing base (bb0f46a) to head (822a89e). Report is 7 commits behind head on develop.

:exclamation: Current head 822a89e differs from pull request most recent head 2cbaa77. Consider uploading reports for the commit 2cbaa77 to get more accurate results

Files Patch % Lines
rocketpy/plots/rocket_plots.py 94.28% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #580 +/- ## =========================================== - Coverage 72.99% 72.94% -0.06% =========================================== Files 59 59 Lines 9543 9612 +69 =========================================== + Hits 6966 7011 +45 - Misses 2577 2601 +24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Gui-FernandesBR commented 6 months ago

Also, @MateusStano can you please test the implementation in a multi-stage rocket? I think the NDRT example notebook may help you with that.

MateusStano commented 5 months ago

Also, @MateusStano can you please test the implementation in a multi-stage rocket? I think the NDRT example notebook may help you with that.

The drawing ends up identical to the way it was before. Did you find any problems there?

Gui-FernandesBR commented 5 months ago

Also, @MateusStano can you please test the implementation in a multi-stage rocket? I think the NDRT example notebook may help you with that.

The drawing ends up identical to the way it was before. Did you find any problems there?

Nope. Sorry, I just did not have enough time to checkout your branch and run the examples.

If you have tested all the examples, I trust you. Go ahead and merge it.