RocketPy-Team / RocketPy

Next generation High-Power Rocketry 6-DOF Trajectory Simulation
https://docs.rocketpy.org/
MIT License
570 stars 137 forks source link

FIX: Optional Dependencies Naming in pyproject.toml. #592

Closed phmbressan closed 2 months ago

phmbressan commented 2 months ago

Pull request type

Checklist

Current behavior

The installation of optional dependencies env-analysis and àll is not working as expected, yielding the following results:

env-analysis install results
pyproject_env

The same happens with `env_analysis`.

"all" install result
pyproject_all

New behavior

Changing the naming of env_anaysis to the python package normalized env-analysis fixes the first installation issue.

The second was the addition of the all to the optional dependencies.

Breaking change

Additional information

The recursive syntax to generate the all in the pyproject.toml file is only supported from pip>=21.2 (from 2021). The + symbol from setup.py is not valid in pyproject.toml.

If this is understood as a too strict version compromise, listing all the dependencies is the alternative.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.03%. Comparing base (1b9e950) to head (c49de29). Report is 2 commits behind head on develop.

:exclamation: Current head c49de29 differs from pull request most recent head 3264dc9. Consider uploading reports for the commit 3264dc9 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #592 +/- ## =========================================== + Coverage 72.97% 73.03% +0.05% =========================================== Files 57 57 Lines 9596 9596 =========================================== + Hits 7003 7008 +5 + Misses 2593 2588 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.