Open phmbressan opened 2 months ago
Attention: Patch coverage is 95.23810%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 73.03%. Comparing base (
43b2b0d
) to head (e020aaa
). Report is 1 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
rocketpy/motors/fluid.py | 87.50% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Current behavior
Currently, the
Tank
class assumes in its computations that its fluid densities are a constant in time. This approximation can be rather inaccurate, specially for tanks that experiment large variations in fluid density (e.g. due to changes in temperature and pressure) during the flow.New behavior
This PR essentially allows for time variable densities when defining the
Fluid
and theTank
subclasses discretize these values in time for code speed.Breaking change
Additional Information
The tests for the
Tank
class would benefit a lot from a refactor. However, I preferred to keep this PR focused on the new functionalities.