RocketPy-Team / RocketPy

Next generation High-Power Rocketry 6-DOF Trajectory Simulation
https://docs.rocketpy.org/
MIT License
570 stars 137 forks source link

ENH: Barometer, ScalarSensors and InertialSensors #608

Closed MateusStano closed 2 weeks ago

MateusStano commented 1 month ago

Pull request type

Checklist

New

I have added the Barometer class. Since this sensor does not have axes, the class structure of the sensors had to change. The old abstract Sensors class still exists, and it inherits to:

The sensor_testing.ipynb notebook has a working barometer

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 92.54386% with 17 lines in your changes missing coverage. Please review.

Project coverage is 73.72%. Comparing base (ce1d179) to head (0b779f2). Report is 1 commits behind head on enh/sensors-impl.

Files Patch % Lines
rocketpy/sensors/sensor.py 90.44% 15 Missing :warning:
rocketpy/plots/rocket_plots.py 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## enh/sensors-impl #608 +/- ## ==================================================== - Coverage 73.78% 73.72% -0.07% ==================================================== Files 64 62 -2 Lines 10049 10064 +15 ==================================================== + Hits 7415 7420 +5 - Misses 2634 2644 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MateusStano commented 4 weeks ago

@Gui-FernandesBR @phmbressan comments addressed, files renamed and most of pylint complaint fixed.