Closed MateusStano closed 2 weeks ago
Attention: Patch coverage is 92.54386%
with 17 lines
in your changes missing coverage. Please review.
Project coverage is 73.72%. Comparing base (
ce1d179
) to head (0b779f2
). Report is 1 commits behind head on enh/sensors-impl.
Files | Patch % | Lines |
---|---|---|
rocketpy/sensors/sensor.py | 90.44% | 15 Missing :warning: |
rocketpy/plots/rocket_plots.py | 50.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Gui-FernandesBR @phmbressan comments addressed, files renamed and most of pylint complaint fixed.
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyNew
I have added the
Barometer
class. Since this sensor does not have axes, the class structure of the sensors had to change. The old abstractSensors
class still exists, and it inherits to:InertialSensors
: Deals with vector measurements. Is inherited byAccelerometer
andGyroscope
ScalarSensors
: Deals with scalar measurements. Is inherited only byBarometer
for nowThe
sensor_testing.ipynb
notebook has a working barometer