RocketPy-Team / RocketPy

Next generation High-Power Rocketry 6-DOF Trajectory Simulation
https://docs.rocketpy.org/
MIT License
616 stars 146 forks source link

BUG: Fixes nose cone bluffness issue #610 #611

Closed Lucas-Prates closed 4 months ago

Lucas-Prates commented 4 months ago

Pull request type

Bug fix issue #610 .

Checklist

Current behavior

The find_radius method inside the NoseCone class computes the square of its argument x. The lambda function, however, passes a list to it, causing a TypeError.

New behavior

Just pass the value instead of the list.

Breaking change

Lucas-Prates commented 4 months ago

As suggested by @Gui-FernandesBR, this might be a good indication to expand unit tests for aero_surface classes. This seems like an error that would have been caught by tests.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.56%. Comparing base (209434f) to head (836cde7). Report is 1 commits behind head on develop.

Files Patch % Lines
rocketpy/rocket/aero_surface.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #611 +/- ## =========================================== - Coverage 73.60% 73.56% -0.05% =========================================== Files 70 70 Lines 10310 10313 +3 =========================================== - Hits 7589 7587 -2 - Misses 2721 2726 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Gui-FernandesBR commented 4 months ago

As suggested by @Gui-FernandesBR, this might be a good indication to expand unit tests for aero_surface classes. This seems like an error that would have been caught by tests.

Don't worry, we can add more robust tests for aero_surfaces classes in the future. I think @lucasfourier should be aware of this.

Thank you for your fast solution, @Lucas-Prates !! Nice job, we are merging this one.