Closed Lucas-Prates closed 4 months ago
As suggested by @Gui-FernandesBR, this might be a good indication to expand unit tests for aero_surface classes. This seems like an error that would have been caught by tests.
Attention: Patch coverage is 0%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 73.56%. Comparing base (
209434f
) to head (836cde7
). Report is 1 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
rocketpy/rocket/aero_surface.py | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
As suggested by @Gui-FernandesBR, this might be a good indication to expand unit tests for aero_surface classes. This seems like an error that would have been caught by tests.
Don't worry, we can add more robust tests for aero_surfaces classes in the future. I think @lucasfourier should be aware of this.
Thank you for your fast solution, @Lucas-Prates !! Nice job, we are merging this one.
Pull request type
Bug fix issue #610 .
Checklist
black rocketpy/ tests/
) has passed locallyCurrent behavior
The
find_radius
method inside theNoseCone
class computes the square of its argumentx
. The lambda function, however, passes a list to it, causing aTypeError
.New behavior
Just pass the value instead of the list.
Breaking change