RocketPy-Team / RocketPy

Next generation High-Power Rocketry 6-DOF Trajectory Simulation
https://docs.rocketpy.org/
MIT License
570 stars 137 forks source link

DOC: Solve Dependencies Conflicts and pyproject build #613

Closed phmbressan closed 1 month ago

phmbressan commented 1 month ago

Pull request type

Checklist

Note: --runslow is currently failing.

Current behavior

An error occurs while trying building docs due to many reasons, including:

All those library changes happened around late april and beginning of may.

New behavior

The following changes were made:

Following sphinx docs recommendation, in order to avoid breaking docs due to dependency updates pip-tools was used to pin down all docs dependencies.

The following procedure should be followed to add/update a docs dependency:

  1. Add the new top-level dependency to docs/requirements.in;
  2. Run pip-compile docs/requirements.in.
Docs are building now: ![image](https://github.com/RocketPy-Team/RocketPy/assets/87212571/3edb37d1-ec8a-48ab-b7ee-e13fa75e0137)

Breaking change

Additional information

The PR #584 removes README.md from the docs, allowing the removal of m2r2 dependency and the limitation of docutils version.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.56%. Comparing base (836cde7) to head (73ec844). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #613 +/- ## ======================================== Coverage 73.56% 73.56% ======================================== Files 70 70 Lines 10313 10313 ======================================== Hits 7587 7587 Misses 2726 2726 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

phmbressan commented 1 month ago

There are some comments added automatically at the top of docs/requirements.txt which specify what you mentioned.

I don't know if you have seen those, but if you think that it is not enough, I can add a line on top of requirements.in with the same.

Gui-FernandesBR commented 1 month ago

There are some comments added automatically at the top of docs/requirements.txt which specify what you mentioned.

I don't know if you have seen those, but if you think that it is not enough, I can add a line on top of requirements.in with the same.

OK, Good, that's enough, I haven't seen those before. All good.