Closed phmbressan closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.56%. Comparing base (
836cde7
) to head (73ec844
). Report is 1 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
There are some comments added automatically at the top of docs/requirements.txt
which specify what you mentioned.
I don't know if you have seen those, but if you think that it is not enough, I can add a line on top of requirements.in
with the same.
There are some comments added automatically at the top of
docs/requirements.txt
which specify what you mentioned.I don't know if you have seen those, but if you think that it is not enough, I can add a line on top of
requirements.in
with the same.
OK, Good, that's enough, I haven't seen those before. All good.
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Note:
--runslow
is currently failing.Current behavior
An error occurs while trying building docs due to many reasons, including:
docutils
not supported bym2r2
;pyproject.toml
requiresconf.py
changes;lxml
separated itshtml_clean
to another repo for security.All those library changes happened around late april and beginning of may.
New behavior
The following changes were made:
docutils
version to0.20.1
;docs/requirements
the newlxml_html_clean
;PYTHONPATH
toconf.py
.Following sphinx docs recommendation, in order to avoid breaking docs due to dependency updates
pip-tools
was used to pin down all docs dependencies.The following procedure should be followed to add/update a docs dependency:
docs/requirements.in
;pip-compile docs/requirements.in
.Docs are building now:
![image](https://github.com/RocketPy-Team/RocketPy/assets/87212571/3edb37d1-ec8a-48ab-b7ee-e13fa75e0137)Breaking change
Additional information
The PR #584 removes
README.md
from the docs, allowing the removal ofm2r2
dependency and the limitation ofdocutils
version.