RocketPy-Team / RocketPy

Next generation High-Power Rocketry 6-DOF Trajectory Simulation
https://docs.rocketpy.org/
MIT License
648 stars 158 forks source link

ENH: Insert apogee state into solution list during flight simulation #638

Closed Gui-FernandesBR closed 4 months ago

Gui-FernandesBR commented 4 months ago

Pull request type

Checklist

Current behavior

Recently reported on discord: image image image

New behavior

The problem was related to Function interpolations. I added the apogee state to the state solution so it created a point at the minimum value of the free stream speed curve (i.e. the apogee). This way we reduced the error when evaluating the stream speed at apogee.

Breaking change

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.71%. Comparing base (655f4be) to head (673ac84). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #638 +/- ## ======================================== Coverage 75.70% 75.71% ======================================== Files 81 81 Lines 9813 9815 +2 ======================================== + Hits 7429 7431 +2 Misses 2384 2384 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.