RocketPy-Team / RocketPy

Next generation High-Power Rocketry 6-DOF Trajectory Simulation
https://docs.rocketpy.org/
MIT License
648 stars 158 forks source link

ENH: adding rocket radius to RailButtons class #643

Closed juliomachad0 closed 4 months ago

juliomachad0 commented 4 months ago

Pull request type

Checklist

Current behavior

A small change (addition of the rocket_radius attribute) was made to the RailButtons class to resolve issue #606. For the change to work in practical simulations, small changes were made to the rocket.py (add_surfaces method) and flight.py (u_dot_generalized method) files.

New behavior

It is now possible to use the RailButtons class in the way the user tried, without major changes to the code and with everything apparently working.

Breaking change

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.69%. Comparing base (d977fbe) to head (ad67701).

Files Patch % Lines
rocketpy/rocket/rocket.py 33.33% 4 Missing :warning:
rocketpy/simulation/flight.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #643 +/- ## =========================================== - Coverage 75.72% 75.69% -0.03% =========================================== Files 81 81 Lines 9815 9823 +8 =========================================== + Hits 7432 7436 +4 - Misses 2383 2387 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.