RocketPy-Team / RocketPy

Next generation High-Power Rocketry 6-DOF Trajectory Simulation
https://docs.rocketpy.org/
MIT License
650 stars 159 forks source link

BUG: Rollback Prandtl-Glauert corrections for Tail and Nose. #685

Closed phmbressan closed 2 months ago

phmbressan commented 2 months ago

Pull request type

Checklist

Current behavior

Prandtl-Glauert corrections applied to Tail and Nose produced some unexpected behaviors.

New behavior

This PR rollback the Tail and Nose aerodynamic to the earlier state.

Breaking change

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.74%. Comparing base (174aee5) to head (4de4c95). Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #685 +/- ## ======================================= Coverage 75.74% 75.74% ======================================= Files 81 81 Lines 9821 9821 ======================================= Hits 7439 7439 Misses 2382 2382 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Gui-FernandesBR commented 2 months ago

For the future... We should allow users to decide if they want their models to follow one assumption or another.