RocketPy-Team / RocketPy

Next generation High-Power Rocketry 6-DOF Trajectory Simulation
https://docs.rocketpy.org/
MIT License
650 stars 159 forks source link

BUG: Fix `Environment.max_expected_height` for custom atmosphere #707

Closed Gui-FernandesBR closed 1 month ago

Gui-FernandesBR commented 1 month ago

Pull request type

Checklist

Current behavior

Enter text here...

New behavior

Enter text here...

Breaking change

Additional information

Enter text here...

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.90%. Comparing base (b9b44dd) to head (7ce1cad). Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
rocketpy/environment/environment.py 71.42% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #707 +/- ## =========================================== - Coverage 76.02% 75.90% -0.12% =========================================== Files 99 99 Lines 11278 11222 -56 =========================================== - Hits 8574 8518 -56 Misses 2704 2704 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Gui-FernandesBR commented 1 month ago

All tests, including slow tests, are passing locally. The CI is also all checked. it's time to merge.