DOC: Faraday 2023 flight sim

RocketPy-Team / RocketPy

Next generation High-Power Rocketry 6-DOF Trajectory Simulation

https://docs.rocketpy.org/

MIT License

650 stars 159 forks source link

DOC: Faraday 2023 flight sim #734

Closed LUCKIN13 closed 4 days ago

LUCKIN13 commented 6 days ago

Pull request type

[ ] Code changes (bugfix, features)
[ ] Code maintenance (refactoring, formatting, tests)
[x] ReadMe, Docs and GitHub updates

Checklist

[x] Docs have been reviewed and added / updated
[x] Lint (black rocketpy/ tests/) has passed locally
[x] All tests (pytest tests -m slow --runslow) have passed locally
[ ] CHANGELOG.md has been updated (if relevant)

Additional information

This branch still needs some data reviews since the simulation file was developed in an older version of RocketPy. However, reviews can already be made, since the example should only suffer minor changes, if needed. Changelog and Index for examples will be updated in other flight example, to prevent conflicts.

LUCKIN13 commented 6 days ago

Thanks @Gui-FernandesBR for your review. Valid points, almost totally fixed. In terms of the drag data, that's the only data we have. I'll try contacting the team, to see if we can improve that example!

Gui-FernandesBR commented 6 days ago

Thanks @Gui-FernandesBR for your review. Valid points, almost totally fixed. In terms of the drag data, that's the only data we have. I'll try contacting the team, to see if we can improve that example!

Understood.

I noticed the power_on drag is higher than the power_off drag. It should be the opposite tho. If you swap those files, does the results get better or worse? If worse, just forget about what I said.

LUCKIN13 commented 5 days ago

@Gui-FernandesBR just went with the higher value in drag. 30 meters reduction, and I believe that since is a constant drag, it's difficult to reach better results. This can be updated later, if the team gives us more data.

Gui-FernandesBR commented 4 days ago

@Gui-FernandesBR just went with the higher value in drag. 30 meters reduction, and I believe that since is a constant drag, it's difficult to reach better results. This can be updated later, if the team gives us more data.

Great work. That's what I expected. 5% is already really nice.

Off-topic, I believe GitHub has solved a long-known-issue which is the notebook diffs.