Rocketeer007 / php-dynamics-crm-2011

Automatically exported from code.google.com/p/php-dynamics-crm-2011
7 stars 8 forks source link

Move all Utility Functions from the Connector class to the base class #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Currently, there are several utility functions defined in the 
DynamicsCRM2011_Connector class.  

Unless these specifically relate to connecting to the server, they should be 
moved to the DynamicsCRM2011 class, so they can be used in any function on any 
other class in the project.

Original issue reported on code.google.com by N.M.Pr...@gmail.com on 16 Mar 2012 at 2:37

GoogleCodeExporter commented 9 years ago
Needs to be done

Original comment by N.M.Pr...@gmail.com on 16 Mar 2012 at 2:41

GoogleCodeExporter commented 9 years ago
Needs to be done

Original comment by N.M.Pr...@gmail.com on 16 Mar 2012 at 2:41

GoogleCodeExporter commented 9 years ago
I'll pick this one up today

Original comment by N.M.Pr...@gmail.com on 16 Mar 2012 at 9:36

GoogleCodeExporter commented 9 years ago
Clearly, only interested in static functions (if there are any functions that 
are not static, and could be, that's another issue!)

* addAttributes
* addFormattedValues
-- No.  These two functions are too tightly tied into the 
parseRetrieveEntityResponse for them to make sense elsewhere.
* findSecurityPolicy
* findSoapAction
* getAllSoapActions
* getFederatedSecurityAddress
* getLoginXML
* getSecurityHeaderNode
* getTrust13UsernameAddress
* getTrustAddress
-- No.  These functions belong to the Connector, and would not make sense 
elsewhere
* generateXXXRequest
* parseXXXResponse
-- No.  This set of functions are intrinsic to the Connector, and would not 
make sense elsewhere
* generateSoapHeader
* generateSoapRequest
* getSoapResponse
-- No.  Again, intrinsic to the purpose of the Connector, and would be odd on 
(e.g.) an Entity
* getCurrentTime
* getExpiryTime
-- Yes, these could potentially be used anywhere
* setDebug
-- Yes, this would allow Debug options on a wider range of classes

Original comment by N.M.Pr...@gmail.com on 16 Mar 2012 at 9:48

GoogleCodeExporter commented 9 years ago
Done

Original comment by N.M.Pr...@gmail.com on 16 Mar 2012 at 9:53