search

Rocketloop / ng-rocketparts

Angular components that get things done 🚀
MIT License
2 stars 0 forks source link

[Directive] show/hide password input value #13

Closed erzaehlsalex closed 6 years ago

erzaehlsalex commented 6 years ago

I have found a great directive to show / hide password input, but the maintainer stopped working on it almost a year ago. So it only supports Angular 4 and there is already an issue that it is not working with Angular 5+.

We should extract the logic of the directive and implement our own directive that supports Angular 5+.

erzaehlsalex commented 6 years ago

I have found another library for this. This library adds a split input button to password or text input. It works as expected, but I prefer the the icon inside the input more.

I have included the first library, it works, but I had issues with the password manager (last pass) icon that is displayed behind the show / hide icon. I was not able to disable the password manager for the input and honestly disabling the password manager especially for a password input does not make sense. Do you guys have an idea what could be the best out of those two libraries?