search

Rocketloop / ng-rocketparts

Angular components that get things done 🚀
MIT License
2 stars 0 forks source link

[Pipe] MaybeAsyncPipe #3

Closed erzaehlsalex closed 6 years ago

erzaehlsalex commented 6 years ago

We need to extract our MaybeAsyncPipe and expose it as part of this library. We also need to create tests for the pipe, before it can be included in the library.

flore2003 commented 6 years ago

How do we want to handle this pipe in relation to the discussion in #2? I think a separate NgModule for just a single pipe is overkill. Can someone quickly check, if ng-bootstrap exposes pipes, and if yes, how they do it?

ditoglez commented 6 years ago

Haven't found in ng-bootstrap any pipes export but maybe I just missed it. Yeah, I agree that making a module for just one pipe is overkill. What about if for now, we just expose it as a standalone pipe and let the user decide to declare it in their own NgModule or the component she/he wants?

From the other side, we decided to make an NgModule for the number-input-component... 🤔

flore2003 commented 6 years ago

:tada: This issue has been resolved in version 1.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: