Latest snapshot build: Fresh config gives players (and admins) items

[bitrot-alpha]

Describe the bug Upon updating my server to 1.16, deleting the old ItemJoin folder (fresh config), and updating the plugin to the latest snapshot (coming from a stable build) I (and regular players) were given items upon join. I'm pretty sure this isn't supposed to happen, as the last version I had did not do this, and I was free to add items without worrying about other items suddenly appearing when they were triggered.

One of the items had a permission-based trigger, the "Survival Server" item. This was enabled globally. The other, "Magical Cloth." I assume these are demo items.

Because of a very convenient feature, one of the items was also not removable from the player's inventory without clearing it with a command.

To Reproduce Steps to reproduce the behavior:

1. Start fresh with build 511.
2. Start server.
3. Use an opped/admin (permissions.yml: *) account; Use a regular account with player permissions.
4. Login, logout, login again, or even just die and respawn.

Expected behavior If I start with an empty inventory and fresh config, I shouldn't be getting items. Default items should not be enabled globally, or have multiple annoying triggers for items that cannot be removed from inventory in a conventional fashion. The 1.15 release build worked perfectly, and I hope I am contributing to the stability of the next one!

Note I was able to disable the items normally through the GUI, I think. One of my players reported that they received the same items, despite not having the permission node for the "Survival Server" item.

Pastebin config.yml items.yml

Versions: Paper 1.16.1, #136 ItemJoin 5.0.7-SNAPSHOT build 511

Additional context I'm a noob at Github, tell me if I missed something! I am using Plugman, and I am getting a couple ERROR: Not a string errors right at the end of my server finishing loading up. I am running in offline-mode, if that matters. Not sure where the Not a string errors are coming from though. Have a lot of plugins.

Plugins (40): AntiDisconnectSpam, BlockLocker, Bookshelves, Cannons, ChatEx*, ChestShop, ChestSort, ClearLag,
CoreProtect, dynmap*, Essentials, EssentialsSpawn, ExecutableItems, Factions, floodgate-bukkit, Geyser-Spigot, GSit,
IridiumSkyblock, ItemJoin, LoginSecurity*, LuckPerms, Multiverse-Core, Multiverse-NetherPortals,
Multiverse-Portals, PerWorldInventory, PlaceholderAPI, PlotSquared, PlugMan, Ships, SkinsRestorer, UberEnchant, 
Vault, ViaBackwards, ViaRewind, ViaVersion, VoidGenerator, WarpSystem, WorldBorder, WorldEdit, WorldGuard

Screenshots

[RockinChaos]

You have permissions disabled. In the config.yml you need to set Permissions.Obtain-Item and Permissions.Obtain-Item-OP to true which should resolve your issue. By default permissions are disabled because I get so many people everyday asking why they aren't getting the items.

Also forgive my stupidity, but you are aware you can actually delete the default items using the menu instead of only disabling them correct? Via the modify menu and clicking the Redstone to delete it after clicking the item you want to modify?

PS: THANK YOU for the fantastic writeup!!!!

[bitrot-alpha]

I'm prepping my server for the public, so I'm keeping the default items for studying later (I'm aware that I can delete them, thank you for making it obvious in the GUI!). I'll have a look at the wiki and make sure my permissions are in line.

[bitrot-alpha]

Hmm.. maybe you should add something to the lore of the items to tell users to change their config.yml/permissions, if this is going into the 1.16 release