RockinChaos / ItemJoin

Get custom items on join.
https://www.craftationgaming.com/
GNU Lesser General Public License v3.0
132 stars 34 forks source link

negive options with ! #440

Open FakEEE14 opened 2 years ago

FakEEE14 commented 2 years ago

hi

it's possible to add negetive nodes for permission, world and ... in examples players ned permision like permission-node: 'itemjoin.ultra' but this time you do this permission-node: '!itemjoin.ultra' to give the item to pepoles that don't have the permission or we have enabled-regions: region1, region2 enabled-worlds: world, world_nether, world_the_end we can do this enabled-regions: !region1 enabled-worlds: !world to include all worlds/region except the negtive one placeholders and condtion already have this option by setting equal:false

this open a lot of other ways to create and config stuff

RockinChaos commented 2 years ago

So for the enabled-worlds this is already filled with the new feature disabled-worlds. I can also add the same for enabled-regions (disabled-regions) instead of using a negate prefix.

As for the permission-node, this should be possible to implement but it may take some time due to the fact that I need to be sure I implement it in a way without breaking previously set permission-nodes from older versions of ItemJoin.

I will update you when I progress on this.

FakEEE14 commented 2 years ago

awsome and coool thanks

i didn't find disabled-worlds feature in wiki and i didn't dig in the source want me to add it under ? https://github.com/RockinChaos/ItemJoin/wiki/Creating-Items#defining-an-items-enabled-worlds

call me for any help you need

RockinChaos commented 2 years ago

Apologizes for the late reply, I missed your last comment.

That is intentional as the wiki is reserved for official release notes. All features that are currently on the dev branch are located in the Devlog; https://github.com/RockinChaos/ItemJoin/wiki/DevLog

Once the release is live I push an automatic update to the wiki pages that reflect the Devlog changes.