search

RockinChaos / ItemJoin

Get custom items on join.
https://www.craftationgaming.com/
GNU Lesser General Public License v3.0
138 stars 36 forks source link

ItemJoin>Menu>CustomModelData: Preview glass panes should represent the item being selected. #452

Closed ryantheleach closed 1 week ago

ryantheleach commented 2 years ago

Is your feature request related to a problem? Please describe. When creating an itemjoin item from a custom item, the customModelData was ignored. (bug?)

I then attempted to set the CustomModelData using the menu option and discovered that the glass panes had all different button effects.

image

Describe the solution you'd like I would

  1. Like the custom item dropped customModelData to be preserved.
  2. Have the CustomModelData Menu use previews of the item instead, this would allow people to see the items graphically when choosing a model.
RockinChaos commented 2 weeks ago

Sorry this took so long to get to, I implemented some changes to the menu that use the defined item material and apply the model data so you can preview how it would look (aside from the preview you see in the main item definition menu prior to saving).

Link; https://ci.craftationgaming.com/downloads Remember to remove your old ItemJoin.jar file

Let me know!~

EDIT: The official release is now available. Link; https://www.spigotmc.org/resources/itemjoin.12661/download?version=557378