RockinChaos / ItemJoin

Get custom items on join.
https://www.craftationgaming.com/
GNU Lesser General Public License v3.0
137 stars 35 forks source link

Books with clickable text don't work #556

Closed MaxJoker149 closed 9 months ago

MaxJoker149 commented 10 months ago

Server Version

Paper 1.20.1

Resource Version

ItemJoin-6.0.3-SNAPSHOT-b910.jar

Dump Information

https://pastebin.com/wKH12v4T

Describe The Problem

The first book with clickable text that is delivered after the server restarts works fine, but after that the books that are delivered to players stop appearing with clickable text, they stop working...

Additional Context

2023-10-22_02 30 25 2023-10-22_02 30 30

Checklist

RockinChaos commented 10 months ago

Confirmed, turns out the Legacy method for book pages was being activated on all versions. Since it is executed every-time whereas the JSON is executed once it was being overwritten after the first book was given.

A proper version check has been implemented and has now been tested as working. Thanks for the report!

Link; https://ci.craftationgaming.com/job/ItemJoin/912/ Remember to remove your old ItemJoin.jar file