RockinChaos / ItemJoin

Get custom items on join.
https://www.craftationgaming.com/
GNU Lesser General Public License v3.0
137 stars 35 forks source link

Save items but maintain their functionality #569

Open ByShacox opened 8 months ago

ByShacox commented 8 months ago

Server Version

1.19.4

Resource Version

ItemJoin v6.0.3

Dump Information

https://pastebin.com/XQCC03Fs

Describe The Problem

Is there a way to save items but maintain their functionality? I'm talking more specifically about MMOITEMS. When I save an item from mmoitems with the itemjoin menu within the game, it only saves the name and lore of the item but the skills or nothing don't work.

Additional Context

No response

Checklist

RockinChaos commented 8 months ago

So this isn't really something I can implement using the saving feature. It's down to how MMOItems recognizes their items (likely NBT tags) so a potential solution would be to manually add them to the ItemJoin items using the https://github.com/RockinChaos/ItemJoin/wiki/Creating-Items#setting-up-nbtproperties .

Otherwise MMOitems would have to add ItemJoin support.

From a quick glance, it seems like their source code is publicly available so I'll dig around and find out how they identify their items and point you in the right direction.

RockinChaos commented 4 months ago

Okay so I have been looking into this and it does seem possible to add support for MMOitems. I am going to move this to a feature request, but it may take some time to implement as it will take quite a bit of re-coding to implement in order to retain MMOitems functionality.