Closed czerk89 closed 2 months ago
Confirmed, this one was a bigger issue than just clear-items as ItemJoin uses NBT checks for pretty much everything and it was failing the NBT check (or rather passing) when it was an item that could contain NBT by default like weapons and armor.
Apparently, a recent change made these items return an empty NBT after trying to fetch the ItemJoin data instead of null which is what ItemJoin checks for.
I made it catch both cases (null and empty NBT data) which seems to have resolved the issue from my testing.
Link; https://ci.craftationgaming.com/downloads Remember to remove your old ItemJoin.jar file
Thanks again for the bug report! Let me know!~
EDIT: Offical release is now available; Link; https://www.spigotmc.org/resources/itemjoin.12661/download?version=542784
Server Version
paper-1.20.4-454
Resource Version
6.0.5-RELEASE-b928
Dump Information
https://ci.craftationgaming.com/dump?id=ikacokadip
Describe The Bug
I have the config file set to this:
But when I join a world, it clears vanilla items like swords and shields. It doesn't clear items like blocks. Or bones. I haven't tested every item it clears and doesn't clear. Even if I craft the item, like a shield, it still disappears.
Expected Behavior
I would expect it to only clear itemjoin items. I even used
/data
to check the tags of vanilla items to see if anything was off.Steps To Reproduce
Clear-Items
values totrue
/give bone 1
and/give diamond_sword
in a survival world./give diamond_sword
again so you have 3 items in the hot bar--1 itemjoin and 2 vanilla.Clear-Items
type fromITEMJOIN
toVANILLA
.My expected behavior would be that with
ITEMJOIN
, only the map would be gone. And withVANILLA
, both the sword and bone would be gone. Also, if you set{id:DIAMOND_SWOTH}
, then the sword remain with ITEMJOIN, as you would expect. But I shouldn't have to blacklist a vanilla item. I didn't find anything in the wiki about this behavior either. And no existing issue was found.Additional Info
No response
Checklist