RockinChaos / ItemJoin

Get custom items on join.
https://www.craftationgaming.com/
GNU Lesser General Public License v3.0
141 stars 36 forks source link

Incompatible with ItemEdit/ItemTag #594

Open LightFishYT opened 5 months ago

LightFishYT commented 5 months ago

Server Version

Paper 1.20.6

Resource Version

6.0.6-RELEASE-b988

Dump Information

https://ci.craftationgaming.com/dump/?id=evezigidax

Describe The Bug

Doesn't save attributes & effects set on the item with ItemEdit & ItemTag.

Expected Behavior

Should save attributes & effects.

Steps To Reproduce

  1. Install Itemjoin, ItemEdit and ItemTag
  2. Get an item and apply an effect or attribute to it by typing /ie attribute add ATTRIBUTE AMOUNT add_number off_hand or /it effects set EFFECT 1 false
  3. Rejoin and the item will not give effects/attributes

Additional Info

No response

Checklist

RockinChaos commented 5 months ago

Attributes and effects are not saved in general as saving those hasn't been added as a feature, (simply an oversight).

I will add this to the list!~ Might take me a bit to implement as I work on prioritizing bug reports and the upcoming 1.21 Minecraft release.