RockinChaos / ItemJoin

Get custom items on join.
https://www.craftationgaming.com/
GNU Lesser General Public License v3.0
139 stars 36 forks source link

Item Duplication With Chest Sort #606

Closed TylorTurner closed 1 week ago

TylorTurner commented 2 weeks ago

Server Version

1.20.4

Resource Version

v6.0.7

Dump Information

g

Describe The Bug

Using the "Double-Right-Click outside inventory" duplicates inventory items.

https://www.spigotmc.org/resources/chestsort-api.59773/ image

https://github.com/mfnalex/ChestSort/blob/master/HOW_TO_USE_API.md

https://streamable.com/060i0a

Expected Behavior

Item to remain in inventory, currently it works fine with most features from chestsort and CMI clear.

Steps To Reproduce

Make an itemjoin item install chestsort plugin open chest and use "Double-Right-Click outside inventory"

Additional Info

No response

Checklist

RockinChaos commented 2 weeks ago

Thanks for the video, very odd as ItemJoin items are explicitly denied any ChestSort functionality via the hook I made into their API; https://github.com/RockinChaos/ItemJoin/blob/a28bfa9dc26e31df815156c923fa632f7cb75f93/src/main/java/me/RockinChaos/itemjoin/listeners/plugins/ChestSortAPI.java#L39

Either something is borked with their API or I missed something that has changed. Testing this now, I'll let you know what I find.

TylorTurner commented 2 weeks ago

Okay, thank you.

On Tue, Sep 3, 2024, 2:50 PM Jason Watanabe @.***> wrote:

Thanks for the video, very odd as ItemJoin items are explicitly denied any ChestSort functionality via the hook I made into their API; https://github.com/RockinChaos/ItemJoin/blob/a28bfa9dc26e31df815156c923fa632f7cb75f93/src/main/java/me/RockinChaos/itemjoin/listeners/plugins/ChestSortAPI.java#L39

Either something is borked with their API or I missed something that has changed. Testing this now, I'll let you know what I find.

— Reply to this email directly, view it on GitHub https://github.com/RockinChaos/ItemJoin/issues/606#issuecomment-2327309881, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7YQO5KCHCUZJOKNCHT4QP3ZUYHG3AVCNFSM6AAAAABNSSICOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXGMYDSOBYGE . You are receiving this because you authored the thread.Message ID: @.***>

RockinChaos commented 2 weeks ago

Confirmed, seems to be a bug on their end as if you perform it really really slowly it works fine. It seems whatever they do handling their event can't keep up with the inventory contents they are returning.

I simply just fetched the player inventory manually instead of relying on their event and it seems to work perfectly fine now. Thanks for letting me know!~ Link; https://ci.craftationgaming.com/downloads Remember to remove your old ItemJoin.jar file

Let me know!~

EDIT: The official release is now available. Link; https://www.spigotmc.org/resources/itemjoin.12661/download?version=557378

TylorTurner commented 1 week ago

Hey did you fix this? It says completed but reading your last message you were unsure if it was on your end.. Just saw you did a big big update.

OH YEAH I SEE YOU DID, Thank you so much!