Autocrafting book recipes moving crafting slot items

emerickchasse commented 1 day ago

Server Version

PaperSpigot 1.20.1

Resource Version

ItemJoin v6.1.0

Dump Information

https://ci.craftationgaming.com/dump/?id=meqosigeja

Describe The Bug

Autocrafting book, recipes move crafting slot items that are not interatable causing them to shift on hot bar and cant be moved.

Expected Behavior

Not moving the items when using autocraft book (even recipe with items I don't have)

Steps To Reproduce

Set items to crafting slots
Open Autocrafting Recipe book
Choose an item you cant craft
Items will shift into hotbar, even if they are not moveable Before: After:

Additional Info

No response

Checklist

[X] I am running latest version of this resource.
[X] I have read the wiki to make sure it's not an issue with configuration.
[ ] I ticked all of these boxes without actually reading them.
[X] I have checked that my bug report is unique and a previous report does not exist.

RockinChaos commented 22 hours ago

Thanks for providing your dump url, you said 1.20.1 but it looks like your running 1.21.1. In 1.20.5 they changed how the recipe packets work so I implemented a fix back then, but apparently... in 1.21+ they changed it back for whatever reason so this has been broken for some time.

Thanks for reporting the issue! I made some changes and it appears to be functional again in the latest snapshot. Link; https://ci.craftationgaming.com/downloads Remember to remove your old ItemJoin.jar file

Let me know!~

emerickchasse commented 15 hours ago

Remember to remove your old ItemJoin.jar file Yeah you right I am on Paper 1.21.1 sorry. I upgraded to dev build 1043 (v6.1.1-SNAPSHOT-b1043) and still experimenting the same issue.

Here is my new dump: https://ci.craftationgaming.com/dump/?id=ibuwerisok

I tested as OP and non-OP and it's the same thing.

RockinChaos / ItemJoin