search

RocksLabs / kvrocks-operator

Apache License 2.0
36 stars 15 forks source link

ci: add docker build and push ci #21

Closed xiao-jay closed 1 year ago

xiao-jay commented 1 year ago

fix #18 You shoud set github secret 'DOCKER_PASSWORD' and 'DOCKER_PASSWORD' first ,I have success build in local ci https://github.com/xiao-jay/kvrocks-operator/actions/runs/4976932713

image
xiao-jay commented 1 year ago

@ColinChamber please review again

ColinChamber commented 1 year ago

Suggest adding a check-docker job in CI.

  check-docker:
    name: Check Docker image
    needs: [lint-build]
    runs-on: ubuntu-20.04
    steps:
      - uses: actions/checkout@v3
      - uses: docker/build-push-action@v3
        with:
          context: .
          push: false
xiao-jay commented 1 year ago

Suggest adding a check-docker job in CI.

  check-docker:
    name: Check Docker image
    needs: [lint-build]
    runs-on: ubuntu-20.04
    steps:
      - uses: actions/checkout@v3
      - uses: docker/build-push-action@v3
        with:
          context: .
          push: false

May be one pr doing one thing is better ,I will do it in next pr.

ColinChamber commented 1 year ago

Can I have your email? If you're willing, I would like to invite you to join some WeChat groups for kvrocks communities. @xiao-jay

xiao-jay commented 1 year ago

sure，You can send a email to 895006375@qq.com,I will tell you my wechat.it's my honour.