search

RocksLabs / kvrocks-operator

Apache License 2.0
36 stars 15 forks source link

In the standard type, the storage size of PVCs for Sentinel and KVrocks instances can only be the same. #37

Closed ColinChamber closed 1 year ago

ColinChamber commented 1 year ago

The logic for creating PVCs between these two should be distinguished. Kvrocks instances may require larger storage size, but Sentinel does not.

tianshimoyi commented 1 year ago

Sentinel clusters do not require persistent storage

jiayouxujin commented 1 year ago

Thanks @tianshimoyi @ColinChamber Now I've separated the code for kvrocks and sentinel. I'm using deployment to create sentinel, and using emptydir as the data volume. https://github.com/RocksLabs/kvrocks-operator/pull/36/files#diff-46f6482b49eadbf34413755b425c88e4032c00027901225a4feacde6e78b9d44R62

ColinChamber commented 1 year ago

Sentinel clusters do not require persistent storage

Before #36, when creating sentinels, it would call the NewStatefulSet function, which would require persistent storage.