search

RocksLabs / kvrocks-operator

Apache License 2.0
36 stars 15 forks source link

feat: add ci for helm charts repo #59

Closed ducviet00 closed 10 months ago

ducviet00 commented 11 months ago

What

This PR add feature to release helm chart repo for kvrocks-operator

Related issue

How

Please create orphan branch named gh-pages before merge this PR

Changes

ducviet00 commented 11 months ago

@xiao-jay @jiayouxujin please review when you available

ColinChamber commented 11 months ago

The chart release job doesn't work in my repo before adding this line. But your jobexecuted successfully. Can you help me figure this out? @ducviet00

ducviet00 commented 11 months ago

The chart release job doesn't work in my repo before adding this line. But your jobexecuted successfully. Can you help me figure this out? @ducviet00

Could you please check your Workflow permissions in Repo Actions settings ? My forked repo has default Read and write permissions, I think explicit adding your line is the right thing to do.

ColinChamber commented 10 months ago

LGTM, after @jiayouxujin determines the release process, then merge.

jiayouxujin commented 10 months ago

LGTM! Thanks @ducviet00

ducviet00 commented 10 months ago

@ColinChamber @jiayouxujin Please create orphan branch named gh-pages https://github.com/RocksLabs/kvrocks-operator/actions/runs/6464094901/job/17548218354