chore: switch exposed kvrock client to interface

RocksLabs / kvrocks-operator

Apache License 2.0

36 stars 15 forks source link

Closed jiayinzhang-mint closed 9 months ago

jiayinzhang-mint commented 11 months ago

Changes

Construct kvrock client as a interface, which shall be easier to mock for future tests.
Rename sigs.k8s.io/controller-runtime/pkg/client to k8sApiClient to avoid confusion.
Add necessary comments to kvrock client methods.

jiayouxujin commented 9 months ago

Hi, @jiayinzhang-mint I noticed that your PR has some conflicts with the base branch. Could you please rebase it to resolve these issues?

jiayinzhang-mint commented 9 months ago

Hi, @jiayinzhang-mint I noticed that your PR has some conflicts with the base branch. Could you please rebase it to resolve these issues?

Done.

jiayinzhang-mint commented 9 months ago