search

RocksLabs / kvrocks-operator

Apache License 2.0
36 stars 15 forks source link

build: improve the user experience of docker-build #8

Closed jiayouxujin closed 1 year ago

jiayouxujin commented 1 year ago

Hi, This PR is for improving the user experience of docker-build. And the related issue is #6

I intorduce the REGISTRY and TAG in Makefile. And introduce the USE_VENDOR in Dockerfile. I also remove the hard code in Dockerfile about the platform.

Thus, the developer can build image by following commands

# build image with tag "kvrocks.com/kvrockslabs/kvrocks-operator:latest"
make docker-build

# build image with tag "kvrockslabs/kvrocks-operator:latest"
REGISTRY=kvrockslabs make docker-build

# build image with tag "kvrocks.com/kvrockslabs/kvrocks-operator:nightly"
TAG=nightly make docker-build

To build faster (using vendor) by following commands

make docker-build-vendor

Note! the above introduction will be added in the development guide #5

Reminder: There are currently missing essential test cases in the code, and I'm working hard to complete them.

git-hulk commented 1 year ago

Thanks @jiayouxujin