Rocologo
commented
7 years ago Thank you very much for the VERY detailed report tbis make the bug finding alot easier!
If the alias does not work it is because one of your other plugings use the same alias, and the alias will only work for one of them. I know MysteriousHalloween uses mh as well. In this case there is no other alternative than using mobhunt. Maybe i can make setting in config.yml so you can control the alias.
About the reported bugs, i will try to replicate the bugs and then fix them, if i can replicate the bug. I have seen other reports on bags which lost their value, but no one has so far been able replecate the bug. I hope you have found a way, because the i can fix it.
The only way a player can get a bag of gold with a value of 0 is as far as i know only by going into creative mode and then copy a bag of gold. If the player does this, the value will be set to 0 on the copy.
Formula350
(Ignore the Backpack wording. I just quickly made that with the inventory screen from our Backpack plugin)
The one that the (now unavailable) Trinkets plugin had was like that, except it used the full player inventory with the armor slots, preview box, and 2x2 workbench. However, this would work just as well and would easily accomplish what's needed. 
tmellen
Spigot version git-Spigot-de459a2-51263e9 (MC: 1.10.2) (Implementing API version 1.10.2-R0.1-SNAPSHOT) MobHuting ver 5.0.8 MultiVerse v2.5 build 716 Vault 1.5.6-b49 (and tons of others)
First problem is when you have a Bag of Gold in your inventory and switch worlds (not sure if it happens going to The End or Nether, IOW vanilla worlds). What happens initially is all the Hidden lore lines become visible on the Bag of Gold skull. IF you exchange it with /mobhunt money sell <amount> (/mh alias doesn't work with this, despite what various plugin resources claim) then it'll still be recognized by the plugin. However, in my experience, if you switch worlds again, the Hidden lore lines disappear and then the plugin fails to recognize that skull (you lose all of that money). SOMEtimes if a skull isn't recognized anymore and you drop it, it will detect it and say "You've dropped <amount>", whereby picking it back up will fix the issue and allow you to sell it.
Second problem is actually the big one and what was the nail in the coffin for me to disable the new Bag of Gold drop, going back to the old auto-add into a player's balance... Last night one of my testers had two bags in her inventory: One that was 0 dollars, a leftover from having used the Sell command as it can leave behind an empty bag (sometimes/always? intentional/another bug?); the other which was, according to her, worth 0.06 dollars (though I suspect it was worth 6 dollars, but doubt it really matters). From there she said that, out of boredom I presume, tried to get the 6 cents skull to apply to the 0 dollars skull by spam-clicking them together. Eventually what occurred from this was that one of them ended up being worth 110 MILLION dollars (it was not an equal amount), and the other one was worth 68 MILLION dollars!! O_O I asked for her to try and sell them, as I was hoping it was just a small hiccup, alas it wasn't, because she was able to indeed sell them both, verified by the fact that her Balance became 178 Million dollars richer. This sort of issue is, while not too likely to occur, ultimately too large of one to be allowed to persist. It'd completely upset the economy on any server. Hopefully it's just an isolated experience, or easily fixable. I'll happily use the old method, as it'll have the side benefit of lessening the number of drops per kill as well.
Possible work around for both situations: Instead of making it where you collect and hold onto the bags of gold, offer a configuration option to have it drop the bags but to auto apply to their balance once picked up. By doing that you'll eliminate both the glitching of the skull meta (hidden lines), as well as the ability to create a skull with untold worth. This would not actually prevent the other intended usage of the Bags of Gold which is to be able to "store" them, a one could still withdraw money from their balance into a skull to store somewhere. The side-benefit of this would then become that a warning can be given to players to not keep a Bag of Gold in their inventory when running around the server due to the risk of glitching out, which then if they DO, it's on them (and won't be left of to either myself or staff to have to try and sort out). All one might want to do is code into a preventative measure to require at least X-amount of money that be withdrawn into a skull. Example: no decimal amounts, no amount less than 10 dollars, can only have 1 "Bag" skull in your inventory at time otherwise it'll auto-combine them. Perhaps a further failsafe would be to make it where the plugin specifically looks at the skull's name and will combine all skulls monetary values with that matching text. A simple work around to prevent player exploitation (in most cases) would also to hide in an additional, innocuous text formatting code such as "&0&0&fBag of Gold - Value 138.23", where if there is anything other than &0&0&f, it ignores combining it.
Thanks! -Formula350
Bonus Bug? - It's rather trivial and I don't know if it's due to my painfully slow internet connection, as a couple other players helping me test things out haven't seemed to be experiencing the issue, nevertheless there is a brief pause when picking up Bags of Gold. Presumably due to having to intercept the pickup, dropping the item being added to the inventory, then applying that amount to one currently in the inventory. This is exacerbated if you've killed multiple mobs and have a number of them to collect. I also can't say for certain, but having a full inventory may be related to this. I'll have to try and pay attention next time.