search

Rod-Persky / investoscope-easy-update

Updates Investoscope 3 end of day quotes
GNU General Public License v3.0
6 stars 3 forks source link

Investoscope must be open to import data #1

Closed Rod-Persky closed 6 years ago

Rod-Persky commented 7 years ago

👍 please open investoscope haha... I'll fix this

Rod-Persky commented 6 years ago

Well... probably should just add a notification or something

Rod-Persky commented 6 years ago

Starting the updater will result in the following error:

1 b'' b'74:114: execution error: Investoscope 3 got an error: Can\xe2\x80\x99t get document 1. Invalid index. (-1719)\n'

However macOS appears to launch investoscope?

charlietomo commented 6 years ago

FYI I get a similar result to you: 1 b'' b'74:115: execution error: Investoscope 3 got an error: Can\xe2\x80\x99t get document 1. Invalid index. (-1719)\n'

And Investoscope opens and continues the update. I'm running the latest version of your program, macOS 10.13.6 and Investoscope 3.0.15. Wasn't generally an issue for me as I remembered to have the program open :-)

Rod-Persky commented 6 years ago

Your right, so macOS will open the app if it closes. I also closed the app during the update process which results in macOS opening the app again.

It ranks maybe 5/10 on criticality. macOS is quite smart 👍

Rod-Persky commented 6 years ago

Version 2 might benefit from detecting this error and then:

1) waiting for investoscope to open, or 2) asking the user to restart the updater when they are ready and closing

Rod-Persky commented 6 years ago

Since AppleScript opens Investoscope, this should be ok.