search

Rod-Persky / investoscope-easy-update

Updates Investoscope 3 end of day quotes
GNU General Public License v3.0
6 stars 3 forks source link

Issue with latest version - no updates, app closes #9

Closed charlietomo closed 5 years ago

charlietomo commented 5 years ago

Hi @Rod-Persky I just updated to the latest version you released and it doesn't work on my machine :-( I updated the .py file with the same path as the previous version. When I run the new app, it opens with a list of shares, saying "up to date:" and then after a few seconds closes. Python doesn't do any connections to the internet. If I immediately run the older version it cycles through and updates. None of my symbols were up to date.

I can use the old one (but would love the error checking in the new one, as I still get issues with the old one) but am happy to help troubleshoot the new release just let us know what you need. I've got a video of what happens if that helps?

charlietomo commented 5 years ago

Just an update. I waited ~17 hours and tried again, and this time the same new version worked. I didn't change any settings at my end - so I'm not really sure what the issue is? It might be on my machine, but I don't really know what if so.

I am happy to try different things but am not sure what I can do. At the moment both updaters seem a bit sporadic. When they work it is great but often they won't update. Appreciate this is a volunteer project so please don't take this as a criticism. Happy to help but just don't know how (as I'm not a coder...).

Rod-Persky commented 5 years ago

This behaviour comes down to this line here. Essentially the update script will only update the data once per day (as history rarely changes). There may be a bug where the update process fails but still changes the date essentially rendering the update process broken for a day.

Specifically, if the code gets to this point without failing it was assumed that the update succeeded and thus the state (date, and whatever else I need to store between runs) is saved.

Rod-Persky commented 5 years ago

Oh, if you really really really get fed up you can go to ~/.investoscope and delete state.p which stores the last update time... it's safe to delete 👍

delete_state_p

(Yes... I've virtually deleted it a few times 🥇 )