search

RodZill4 / material-maker

A procedural textures authoring and 3D model painting tool based on the Godot game engine
MIT License
3.44k stars 218 forks source link

Load Material From Website dialog cannot load some thumbnails #486

Open rcorre opened 2 years ago

rcorre commented 2 years ago

Material Maker version:

0f3f520f0dca00a94e919e4e76cc5cda48fae8d2

OS/device including version:

Linux 5.18.10-arch1-1

Issue description:

The Load Material From Website dialog does not show thumbnails for many materials, and prints:

ERROR: Error opening file 'user://website_cache/thumbnail_217.png'.
   at: load_image (core/io/image_loader.cpp:55)
ERROR: Error opening file 'user://website_cache/thumbnail_216.png'.
   at: load_image (core/io/image_loader.cpp:55)
ERROR: Error opening file 'user://website_cache/thumbnail_215.png'.
   at: load_image (core/io/image_loader.cpp:55)
ERROR: Error opening file 'user://website_cache/thumbnail_214.png'.
   at: load_image (core/io/image_loader.cpp:55)
ERROR: Error opening file 'user://website_cache/thumbnail_213.png'.
   at: load_image (core/io/image_loader.cpp:55)
ERROR: Error opening file 'user://website_cache/thumbnail_212.png'.
   at: load_image (core/io/image_loader.cpp:55)
ERROR: Error opening file 'user://website_cache/thumbnail_211.png'.
   at: load_image (core/io/image_loader.cpp:55)
ERROR: Error opening file 'user://website_cache/thumbnail_210.png'.
   at: load_image (core/io/image_loader.cpp:55)

Steps to reproduce:

  1. Click "File > Load Material From Website"
  2. Type a search term like "ground" 1658070828
RodZill4 commented 1 year ago

MM loads all thumbnails sequentially, it can take some time to load them all. Maybe a good way of fixing this would be to prioritize materials that are displayed in the list.

rcorre commented 1 year ago

Are all the error messages about loading thumbnails expected?

RodZill4 commented 1 year ago

Yes, the error message is there in 1.0 (it's not a problem), but has been removed for 1.1.