[Proposal] Update theme

RodZill4 / material-maker

A procedural textures authoring and 3D model painting tool based on the Godot game engine

MIT License

3.53k stars 222 forks source link

[Proposal] Update theme #76

Closed Grumoth closed 4 years ago

Grumoth commented 4 years ago

Hi, what about updating the Theme to the modern Godot one? It's only a couple clicks. Shall I make a PR with something like this or you are fine with the current one? Thanks!

RodZill4 commented 4 years ago

I really don't like how the treeview looks... but I like the idea of updating the theme. Maybe even provide several themes like Pixelorama...

Calinou commented 4 years ago

I'm working on a new theme in this branch: https://github.com/Calinou/godot-procedural-textures/tree/new-theme

Preview

I'd advise against using a theme generated from the editor, as it contains lots of unneeded resources that will bloat the theme file (and slow down loading).

RodZill4 commented 4 years ago

@Calinou Looks very nice, new default theme! ;) I pushed (to master) a theme selection menu with 3 fat themes... I'll update them later, based on yours whenever it's ready.

Calinou commented 4 years ago

@RodZill4 The current theme I'm working on is hand-made in the Godot theme editor. If we were to add a theme selection menu, we'd have to change all themes manually every time we need to change something :slightly_frowning_face:

One way to solve this is to generate themes by code so we can have color variants without duplicated work. This is how the Godot editor themes are generated (it can be done in GDScript too). I'd like to provide a light theme option, but I don't think it's critical for now.

RodZill4 commented 4 years ago

I was thinking about using your theme as starting point, and introduce (by script) settings from the others. I tried using a Godot script, but it didn't work as expected, so I guess I will directly process the .tres files. So there will be only 1 "reference theme" (yours), and variations generated from it.

RodZill4 commented 4 years ago

@Calinou I added a small script to optimize themes generated in Godot (it tries to grab all images and saves them as PNG). It needs to be run twice because it needs Godot to reload resources to create a correct theme.

RodZill4 commented 4 years ago

@Calinou Any news about your theme? It looks way better than Godot's default (particularly regarding nodes). Looking at your screenshot, maybe make sure nodes are not bigger than they were (seems spacing between parameters is a bit larger) and it would be perfect. I'm really bad at creating themes (and everything art related)...

Calinou commented 4 years ago

@RodZill4 I'm currently busy working on other projects, so it will take a few weeks before the new theme can be production-ready.

RodZill4 commented 4 years ago

@Calinou OK, thanks! Not sure when I'm ready for next release anyway...