Bugs encountered when running on KDE (Kubuntu, GNU/Linux)

RoderickQiu / wnr

⏱️ Work/Rest Timer. Stricter. Prettier. More features. Win/Mac/Linux. (NEW UPDATES PAUSED.)

https://getwnr.com/

Mozilla Public License 2.0

932 stars 59 forks source link

Bugs encountered when running on KDE (Kubuntu, GNU/Linux) #47

Open NKID00 opened 2 years ago

NKID00 commented 2 years ago

Test environment
OS: Kubuntu 21.04 x86_64
Kernel: 5.11.0-34-lowlatency
DE: Plasma 5.21.4
WM: KWin

[x] Tray icon is missing.

[x] Uncaught exception at start up. (Caused by the missing tray icon.)

TypeError: Cannot read property 'setTitle' of null
at IpcMainImpl.<anonymous> (wnr/main.js:2093:19)
at IpcMainImpl.emit (events.js:315:20)
at Object.<anonymous> (electron/js2c/browser_init.js:161:9692)
at Object.emit (events.js:315:20)
at Object.callbackTrampoline (internal/async_hooks.js:131:14)

[x] Tray tool tip is electron, not wnr. (After the tray icon is added manually.)
[ ] Left clicking the tray icon only has the same effect as a right-click. (After the tray icon is added manually.)
[ ] Focus is given to the menu icon (at the top-left corner of the main window) after making the main window shown up by the 'Show / Hide' button from the tray menu. (After the tray icon is added manually.)
[ ] Virtual desktops are not blocked by full-screen focus mode.

RoderickQiu commented 2 years ago

Thanks! I assume the tray stuff be practical to be fixed, however, the last bug may need to make a complete new solution for it in the worst occasion (hopefully not, or a specified warning giver function might be a must...) Also, if you are free, you may check about whether all the settings items really do their jobs fully on Linux, thank you dude. Moreover, other things like the electron-build bridge (/res/builder/ to set) might get broken.

NKID00 commented 2 years ago

The right-click and double-click events of the class Tray are only available on macOS and Windows. This may require a change by Electron.

RoderickQiu commented 2 years ago

Yeah, you're right. Currently I can bear with the workaround of disable the former left-click behaviour of show/hide on Linux. Or if you feel like it, you can issue it to Electron. And, is the transparent icon fixable or that you can go with it?

RoderickQiu commented 2 years ago

Anyway, I think I'm gotta release the new version. In case you have some new ideas, I can perform a hotfix to the release, which is to say, to replace the appimage of the release manually.

NKID00 commented 2 years ago

Yeah, you're right. Currently I can bear with the workaround of disable the former left-click behaviour of show/hide on Linux. Or if you feel like it, you can issue it to Electron. And, is the transparent icon fixable or that you can go with it?

This transparent icon issue does not affect normal use, only looks a bit weird though. I'll open another issue with more details later.