search

RoelKroes / TBTracker

RTTY and LoRa High Altitude Balloon Tracker for Arduino and SX127x
29 stars 10 forks source link

Minor consistency changes #14

Closed KevWal closed 3 years ago

KevWal commented 3 years ago

Hi Roel

Hope your well. I am looking at using your code for a new tracker of mine, and looking through I did a few minor changes that you may wish to include in your master. If you want to keep it as is and reject these, no problems at all! :)

In my Arduino core sleep() is already used, so I renamed your sleep to my_sleep().

You generally use capitalisation in filenames for first letters and abbreviations - changed settings.h, gps.ino and RADIO.ino to match that convention.

The fsk object initially confused me, changed to radio in line with the RadioLib examples as a more generic description of the radio module.

Cheers Kev

RoelKroes commented 3 years ago

Thanks Kev for taking the time to make these improvements to the software! Really appreciated and I've merged them all.