search

RoelofBerg / limereg

Lightweight, derivative based, rigid, 2D Image Registration
http://www.berg-solutions.de/limereg.html
Other
7 stars 5 forks source link

Invalid memory access #2

Open RoelofBerg opened 8 years ago

RoelofBerg commented 8 years ago

According to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=798601 the GCC stack protector was complaining in one of the unit tests on MIPS.

This could be a critical security issue (BOF).

ToDo: After analysis (and possibly fix) inform the Debian package maintainer to revert the compiler switch modifications.

jcowgill commented 7 years ago

FYI I posted a fix for this in the above Debian bug report. It was simply caused by an uninitialized variable in the testsuite.

--- a/tests/test_searchSubimage.c
+++ b/tests/test_searchSubimage.c
@@ -86,6 +86,7 @@ bool test_searchSubimage()
    const unsigned int skipLvl=2;
    struct Limereg_AdvancedRegControl advancedRegControl;
    advancedRegControl.maxIterations = 50;
+   advancedRegControl.stopSensitivity = 0;
    advancedRegControl.pyramidLevelCount = pyramidLvl;
    advancedRegControl.skipFineLevelCount = skipLvl;
    advancedRegControl.startParameters = &startParams;
mapreri commented 7 years ago

FWIW, I confirm that with this patch imereg built successfully in mips.

RoelofBerg commented 7 years ago

Great, thanks. At the moment it's difficult for me to find enough time for maintaining. (For good and several reasons). I'll try harder to give it more priority and upstream it.

Thanks a lot.

On 03.05.2017 20:12, Mattia Rizzolo wrote:

FWIW, I confirm that with this patch imereg built successfully in mips.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RoelofBerg/limereg/issues/2#issuecomment-298991423, or mute the thread https://github.com/notifications/unsubscribe-auth/AGtimrOspl6vLQyQb8-GcW13TVXGGIUGks5r2MOOgaJpZM4HQobz.