search

Roenbaeck / bareclad

Based on transitional modeling, bareclad is a new type of database that provides features from relational, graph, columnar, and name-value pair databases.
http://www.bareclad.com
Other
17 stars 0 forks source link

Code review improvements #1

Closed Kestrer closed 4 years ago

Kestrer commented 4 years ago

Final improvements from the code review.

The issues you were having with replacing &'static str with String are because of https://github.com/billyrieger/bimap-rs/issues/16. By the way the bimap functionality of the bimap isn't actually used at all - are you sure you need a bimap?

Roenbaeck commented 4 years ago

I could switch to a HashMap and ensure that a given String stays associated with a single Role using a few extra lines of code. Likely better in the long run to minimize the external dependencies.