search

Roestlab / massdash

MassDash: A web-based dashboard for streamlined DIA-MS visualization, analysis, prototyping, and optimization
https://massdash.streamlit.app/
BSD 3-Clause "New" or "Revised" License
16 stars 3 forks source link

refactor: combine preprocessor with conformer #101

Closed jcharkow closed 5 months ago

jcharkow commented 5 months ago

Preprocessor and conformer were requiring many of the same attributes. Instead of passing many of the attributes to one another combined the classes. Preprocessor methods are private because they are more complex.

Also move some preprocessor functions to transformations

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Tested using the GUI

Contents (#101)

Other

jcharkow commented 5 months ago

@irahorecka do you know why this is failing on mac?

irahorecka commented 5 months ago

Hi - is this still an issue? What's breaking?

singjc commented 5 months ago

I don't think it's an issue now, just had to re-run the test

jcharkow commented 5 months ago

Hi - is this still an issue? What's breaking?

sorry yes it was failing before but now it is good