When performing peak picking with Conformer, depending on the peptide selected, a value error is thrown due to issues with incorrect dimensions. This is due to the adjust_length method when length < len(self.data):. The current method slices the data 1 point to the left and one point to the right, which results in data with single dimension data point.
I fixed the method to perform proper data trimming on the left and right. I also added unittests for Data1D.
Fixes #108
Type of change
Please delete options that are not relevant.
[x] Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Added unittests for Data1D class.
Checklist:
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
Description
When performing peak picking with Conformer, depending on the peptide selected, a value error is thrown due to issues with incorrect dimensions. This is due to the
adjust_lengthmethod whenlength < len(self.data):. The current method slices the data 1 point to the left and one point to the right, which results in data with single dimension data point.I fixed the method to perform proper data trimming on the left and right. I also added unittests for Data1D.
Fixes #108
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added unittests for Data1D class.
Checklist:
Contents (#109)
Other