Roestlab / massdash

MassDash: A web-based dashboard for streamlined DIA-MS visualization, analysis, prototyping, and optimization
https://massdash.streamlit.app/
BSD 3-Clause "New" or "Revised" License
18 stars 3 forks source link

Refactor/pyopenms viz no streamlit #151

Closed jcharkow closed 3 weeks ago

jcharkow commented 3 weeks ago

Description

Integrates pyopenms_viz plotting with the python plot_chromatogram function. Relevant tests should be in pyopenms_viz

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist:

Other

Uncategorised!

jcharkow commented 3 weeks ago

Note: This updates bokeh to 3.0 which has breaking changes with bokeh 2.4.3. Thus currently old plotting does not work with this PR.

singjc commented 3 weeks ago

Note: This updates bokeh to 3.0 which has breaking changes with bokeh 2.4.3. Thus currently old plotting does not work with this PR.

I added a workaround to get bokeh 3.x working with the current version of streamlit to this PR, tested the example sqMass and raw data workflow in GUI and it works fine with rendering the plots. Everything else looks good.

If you're fine with including the bokeh 3.x fix in this PR, you can go ahead and merge.