Roestlab / massdash

MassDash: A web-based dashboard for streamlined DIA-MS visualization, analysis, prototyping, and optimization

https://massdash.streamlit.app/

BSD 3-Clause "New" or "Revised" License

16 stars 3 forks source link

[BUG?] pyPeakPickerMRM #38

Closed singjc closed 10 months ago

singjc commented 10 months ago

I think there might be something wrong with the pyPeakPickerMRM implementation, it's not even picking peaks that would be considered peaks?

On the other hand, the MRMTransitionGroupPicker seems to work nicely

But there still is some issue with the area from the TransitionGroupFeature objects. I use the area value to set the hight of the peak boundary bar, but it seems the intensity is greater than the peaks itself

jcharkow commented 10 months ago

Thanks for pointing this out I will look into this

singjc commented 10 months ago

40 seems to fix the issue :+1:

still seems to overshoot the aggregated apex intensity, but it does picker the peaks I would expect now