search

Roestlab / massdash

MassDash: A web-based dashboard for streamlined DIA-MS visualization, analysis, prototyping, and optimization
https://massdash.streamlit.app/
BSD 3-Clause "New" or "Revised" License
16 stars 3 forks source link

Patch/refactor UI #39

Closed singjc closed 10 months ago

singjc commented 10 months ago

Major refactoring of UI

singjc commented 10 months ago

Great job overall massive improvements in readability. Main question I had was why masseerGUI object has instances of the class and the class also has instances of it seems kind of redundant however I am not too familiar with streamlit. Also Curious if it makes sense to have an abstract class for all the UI setting objects?

I'm not too sure about having and abstract class for all UI setting objects. They only all share a create_ui method, so could be useful, but some of them do have different attributes/inputs. Not sure how useful it would be :shrug:

jcharkow commented 10 months ago

Once you fix this feel free to merge. No need for another review