search

Roestlab / massdash

MassDash: A web-based dashboard for streamlined DIA-MS visualization, analysis, prototyping, and optimization
https://massdash.streamlit.app/
BSD 3-Clause "New" or "Revised" License
16 stars 3 forks source link

Patch/transition group refactor #55

Closed jcharkow closed 7 months ago

jcharkow commented 7 months ago

Do some refactoring of structs based on suggestions @singjc and I talked about yesterday. This will setup for easier merging of a refactored raw transition extraction.

  1. TransitionGroup now only takes 1 data object
  2. Mobilogram, Chromatogram and Spectrum all inherit from a common Data1D abstract class
singjc commented 7 months ago

Looks good! I just made some minor comments, but it looks good to merge. Can you do me a favour, and also add these changes to the feature/rawdata branch, because this would probably change stuff up for that PR

jcharkow commented 7 months ago

Thanks I will merge! Also will add to the feature/rawdata branch