search

Roestlab / massdash

MassDash: A web-based dashboard for streamlined DIA-MS visualization, analysis, prototyping, and optimization
https://massdash.streamlit.app/
BSD 3-Clause "New" or "Revised" License
16 stars 3 forks source link

Plot Interface Refactoring #62

Open jcharkow opened 6 months ago

jcharkow commented 6 months ago

Refactor plotting documentation for easier interaction with python interface/jupyter notebook interface. I am not too sure which strategy would be best.

Some ideas:

Remove the config interface and directly take in parameters on initiation.

plotting methods directly built into structs?

singjc commented 6 months ago

I kind of like the config interface to avoid having too many parameters in the method call, unless we use **kwargs to pass parameters directly to the plotting (bokeh figure/ plotly figure) interfaces (which may be limited).

I like the idea of having the plotting methods also directly part of the structs.

jcharkow commented 6 months ago

I don't mind the config its just don't really like how some parameters are not relevant for certain plots. Maybe the plot config should be directly parameters of the respective plotters? not a general thing? I am not sure will have to think about it more

jcharkow commented 4 months ago

Some refactoring was done in the https://github.com/Roestlab/massdash/pull/106 More refactoring might need to be done?