Patch/notebook plotting - Githubissues

Roestlab / massdash

MassDash: A web-based dashboard for streamlined DIA-MS visualization, analysis, prototyping, and optimization

https://massdash.streamlit.app/

BSD 3-Clause "New" or "Revised" License

16 stars 3 forks source link

Patch/notebook plotting #63

Closed jcharkow closed 6 months ago

jcharkow commented 6 months ago

Minor changes to make plotting a bit less clunky on jupyter notebook interface.

Store the latest plot in the plotter object
show() method for displaying bokeh plots and plotly plots
add 'context' for default display in notebook

Also added a method to plot directly from TransitionGroupFeature.

Ideally, if this does not break anything from the GUI side we can push these changes with the jos_rawdata_2 changes

jcharkow commented 6 months ago

hold off on review for now seem to be running into circular imports

jcharkow commented 6 months ago

Ok i moved the import statements inside the function to address circular input for now

singjc commented 6 months ago

Looks good. Made some minor comments if you can address those, and can you also test this with patch/josh_rawdata_2, just to make sure it still works in the GUI context as expected, before merging.

jcharkow commented 6 months ago

I don't see your comments? can you make sure you submitted the review?

jcharkow commented 6 months ago

Everything looks good with the GUI as well. I believe it is ready for merging. However one issue which I have in both (but do not think it is related to this PR) is that the surface plots seem to have negative intensity. is that normal?