search

Roestlab / massdash

MassDash: A web-based dashboard for streamlined DIA-MS visualization, analysis, prototyping, and optimization
https://massdash.streamlit.app/
BSD 3-Clause "New" or "Revised" License
16 stars 3 forks source link

Patch/theme logo switch #83

Closed singjc closed 8 months ago

singjc commented 8 months ago

Added theme detection using javascript. This will detect if the theme is dark or light, and use the appropriate logo. This however, will only detect the theme on the initial load of the app or if the app is refreshed, it will not detect a change in theme if it is changed via the settings (unless refreshed).

See:

https://discuss.streamlit.io/t/check-if-the-app-is-in-dark-mode-or-light-mode-at-runtime/20222/8

singjc commented 8 months ago

Can you add this dependency in pyproject.toml? I believe pyproject.toml is what's pushed as a PyPI dependency for pip installs, while setup.cfg is metadata for the PyPI project landing page

Done :+1:

irahorecka commented 8 months ago

Looks good! I'll go ahead and merge this.