search

Roger-luo / Configurations.jl

Options & Configurations made easy.
https://configurations.rogerluo.dev/stable
MIT License
80 stars 12 forks source link

fix #27,#28 #29

Closed Roger-luo closed 3 years ago

Roger-luo commented 3 years ago

this should fix #27

I think @fonsp forget to change the test in #28 so that test fails, I somehow wrote the wrong unit test. I just copied your solution here.

codecov[bot] commented 3 years ago

Codecov Report

Merging #29 (a381cd7) into master (63e5d2a) will decrease coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   92.98%   92.95%   -0.03%     
==========================================
  Files           9        8       -1     
  Lines         285      284       -1     
==========================================
- Hits          265      264       -1     
  Misses         20       20
Impacted Files Coverage Δ
src/parse.jl 98.30% <100.00%> (+0.02%) :arrow_up:
src/serialize.jl 89.18% <0.00%> (-0.29%) :arrow_down:
src/printing.jl 95.23% <0.00%> (-0.12%) :arrow_down:
src/Configurations.jl

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 63e5d2a...a381cd7. Read the comment docs.