Closed Roger-luo closed 3 years ago
Merging #52 (8b7976f) into master (4d8e8e2) will decrease coverage by
0.22%
. The diff coverage is99.13%
.
@@ Coverage Diff @@
## master #52 +/- ##
===========================================
- Coverage 100.00% 99.77% -0.23%
===========================================
Files 7 8 +1
Lines 337 440 +103
===========================================
+ Hits 337 439 +102
- Misses 0 1 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/Configurations.jl | 75.00% <66.66%> (ø) |
|
src/codegen.jl | 100.00% <100.00%> (ø) |
|
src/parse.jl | 100.00% <100.00%> (ø) |
|
src/serialize.jl | 100.00% <100.00%> (ø) |
|
src/types.jl | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4d8e8e2...8b7976f. Read the comment docs.
this PR:
Maybe
since we are using this to denote optional fields, if the default value is not specified, it should have default valuenothing
by definitionReflect
since it doesn't make sense to manually typeReflect
twice