search

Roger-luo / Configurations.jl

Options & Configurations made easy.
https://configurations.rogerluo.dev/stable
MIT License
80 stars 12 forks source link

Create Invalidations.yml #81

Closed ranocha closed 2 years ago

ranocha commented 2 years ago

is is based on https://github.com/julia-actions/julia-invalidations. Adding such checks came up in https://discourse.julialang.org/t/potential-performance-regressions-in-julia-1-8-for-special-un-precompiled-type-dispatches-and-how-to-fix-them/86359. I suggest to add this check here since this package is widely used as a dependency.

See also SciML/MuladdMacro.jl#26 and SciML/MuladdMacro.jl#29

Roger-luo commented 2 years ago

Thanks! Let me wait the CI a bit.

Yeah this looks good to me. I'd also suggest downstream packages always check the invalidations (if latency is something one cares about) and fix them in upstream here since this package is more a codegen rather than a concrete implementation.

ranocha commented 2 years ago

Sure, I also submitted more PRs like this to other packages - but not to all packages, of course. Let's see whether it will have an effect in the long run.